Hi, On Mon, 2012-03-12 at 13:27 +0200, Grazvydas Ignotas wrote: > With this we can eliminate some duplicate code in panel drivers. > Also lgphilips-lb035q02, nec-nl8048hl11-01b, picodlp and > tpo-td043mtea1 gain support of timings control over sysfs.
I don't like this patch. Panels usually have a single, fixed timing configuration that should be used, like the ones you mention above. There's no need to alter the timings. But it's true that there's some duplicate code currently in the panel drivers. However, adding just simple funcs like you did in this patch doesn't work quite properly. There should be locking (for example to prevent disabling the panel while timings are being set), and currently the locking is panel driver specific. Tomi
signature.asc
Description: This is a digitally signed message part
