* Tero Kristo <t-kri...@ti.com> [120420 02:39]: > + > +static int omap4_sar_not_accessible(void) > +{ > + u32 usbhost_state, usbtll_state; > + > + /* > + * Make sure that USB host and TLL modules are not > + * enabled before attempting to save the context > + * registers, otherwise this will trigger an exception. > + */ > + usbhost_state = omap4_cminst_read_inst_reg(OMAP4430_CM2_PARTITION, > + OMAP4430_CM2_L3INIT_INST, > + > OMAP4_CM_L3INIT_USB_HOST_CLKCTRL_OFFSET) > + & (OMAP4430_STBYST_MASK | OMAP4430_IDLEST_MASK); > + > + usbtll_state = omap4_cminst_read_inst_reg(OMAP4430_CM2_PARTITION, > + OMAP4430_CM2_L3INIT_INST, > + > OMAP4_CM_L3INIT_USB_TLL_CLKCTRL_OFFSET) > + & OMAP4430_IDLEST_MASK;
Formatting here looks bad, maybe just do it in separate steps: usbhost_state = omap4_cminst... usbhost_state &= OMAP4430_STBYST_MASK | OMAP4430_IDLEST_MASK; ... > + /* > + * Not supported on ES1.0 silicon > + */ > + if (omap_rev() == OMAP4430_REV_ES1_0) { > + WARN_ONCE(1, "omap4: SAR backup not supported on ES1.0 ..\n"); > + return -ENODEV; > + } Everytime there's SoC/hardware revision detection in a non __init function, something is most likely wrong. > +void omap4_sar_overwrite(void) > +{ > + u32 val = 0; > + u32 offset = 0; > + > + if (cpu_is_omap446x()) > + offset = 0x04; Here too. > +static int __init omap4_sar_ram_init(void) > +{ > + /* > + * To avoid code running on other OMAPs in > + * multi-omap builds > + */ > + if (!cpu_is_omap44xx()) > + return -ENODEV; You should configure things here instead by setting function pointers or variables. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html