On Wed, May 9, 2012 at 8:48 AM, Olof Johansson <[email protected]> wrote:
> Hi,
>
> On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <[email protected]> wrote:
>> The following changes since commit 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
> [..]
>> Enrico Butera (1):
>>      ARM: OMAP: igep0020: fix smsc911x dummy regulator id
>
> Hmm. Picking 40 without any kind of comment in the code isn't doing
> any favors for future readers. Seems like 1 would be free on this
> board, from the rest of the board file to judge (one other
> reg-fixed-regulator platform device)?
>
> Please either comment why you picked 40 (i.e. it's a random number),
> or change it to something a little less random like 1. :)

Yes i verified that 1 is free, i will send an updated patch.

Enrico
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to