> -----Original Message-----
> From: Tomi Valkeinen [mailto:[email protected]]
> Sent: Wednesday, May 09, 2012 3:16 AM
> To: Ashwin Bihari
> Cc: linux-omap; Tony Lindgren
> Subject: Re: [PATCH 2/2] Add LCD support for the LogicPD OMAP3530 DevKits
<snip>
> > +static int omap3logic_panel_enable_lcd(struct omap_dss_device
> > +*dssdev) {
> > + gpio_set_value(LCD_PANEL_PWR, 1);
> > + if (machine_is_omap3530_lv_som())
> > + gpio_set_value(OMAP3530_LV_SOM_BACKLIGHT_PWR, 1);
> > + else if (machine_is_omap3_torpedo()) {
> > + gpio_set_value(OMAP3530_TORPEDO_BACKLIGHT_PWR, 1);
> > +
> > + gpio_set_value(OMAP3530_TORPEDO_MDISP, 1);
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int omap3logic_panel_disable_lcd(struct omap_dss_device
> > +*dssdev) {
> > + gpio_set_value(LCD_PANEL_PWR, 0);
> > + if (machine_is_omap3530_lv_som())
> > + gpio_set_value(OMAP3530_LV_SOM_BACKLIGHT_PWR, 0);
> > + else if (machine_is_omap3_torpedo()) {
> > + gpio_set_value(OMAP3530_TORPEDO_BACKLIGHT_PWR, 0);
> > +
> > + gpio_set_value(OMAP3530_TORPEDO_MDISP, 0);
> > + }
> > +
> > + return 0;
> > +}
>
> This doesn't play well with device-tree. We can't do such callbacks when we
> move to DT.
>
> I know we have similar code for other boards, and this can't be properly fixed
> right now, but I'm still a bit hesitant to add more such code because I'm the
> one that has to clean it up later for DT =).
>
> I can handle the LCD_PANEL_PWR gpio, but the backlight is something that
> should be removed from the panel enable callbacks. You could look at
> drivers/video/backlight/ and see if there's something there that could be
> used for your board. Or implement a new BL driver, if nothing fits.
>
> Tomi
Tomi,
Let me take a look at your linux-omap-dss2 tree and learn a bit more about DT
and figure out how to modify the LCD support so it better aligns with your work
and I'll re-submit that patch again..
Thanks
-- -- --
~ Ashwin
