Hi, Similar comments to the asess patch on this one below.
* Paul Walmsley <[email protected]> [120610 17:57]: > --- /dev/null > +++ b/include/linux/platform_data/fsusb.h This would be better as include/linux/platform_data/omap-usb.h. > +#include <plat/omap_hwmod.h> This include should not be needed here if the hwmod function is a static function in the some hwmod*.c file. > +/* HCCOMMANDSTATUS: the register offset of the HCCOMMANDSTATUS register */ > +#define HCCOMMANDSTATUS 0x0008 > + > +/* HCCOMMANDSTATUS_HCR: the bitmask of the host controller reset flag */ > +#define HCCOMMANDSTATUS_HCR_MASK (1 << 0) I think these already have standard defines in some OHCI header? Felipe may be able to comment more on this? > +static int fsusb_reset_host_controller(const char *name, void __iomem *base) > +{ > + int i; > + > + writel(HCCOMMANDSTATUS_HCR_MASK, base + HCCOMMANDSTATUS); > + > + for (i = 0; i < MAX_FSUSB_HCR_TIME; i++) { > + if (!(readl(base + HCCOMMANDSTATUS) & HCCOMMANDSTATUS_HCR_MASK)) > + break; > + udelay(1); > + } > + > + if (i == MAX_FSUSB_HCR_TIME) { > + pr_warn("%s: %s: host controller reset failed (waited %d > usec)\n", > + __func__, name, MAX_FSUSB_HCR_TIME); > + return -EBUSY; > + } > + > + return 0; > +} This should be "static inline int fsusb_reset_host_controller" as it's in a header. > +static int __maybe_unused hwmod_fsusb_preprogram(struct omap_hwmod *oh) > +{ > + void __iomem *va; > + > + va = omap_hwmod_get_mpu_rt_va(oh); > + if (!va) > + return -EINVAL; > + > + fsusb_reset_host_controller(oh->name, va); > + > + return 0; > +} And this too should be a static function in some hwmod*.c file. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
