Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

[Paul Walmsley]

Hi Benoît

On Wed, 4 Jul 2012, Benoit Cousson wrote:

> > From: Paul Walmsley <p...@pwsan.com>
> > Date: Wed, 4 Jul 2012 05:22:53 -0600
> > Subject: [PATCH] ARM: OMAP2+: hwmod code/clockdomain data: fix 32K sync 
> > timer
> 
> [...]
> 
> > @@ -1208,8 +1219,13 @@ static void _idle_sysc(struct omap_hwmod *oh)
> >     sf = oh->class->sysc->sysc_flags;
> >  
> >     if (sf & SYSC_HAS_SIDLEMODE) {
> > -           idlemode = (oh->flags & HWMOD_SWSUP_SIDLE) ?
> > -                   HWMOD_IDLEMODE_FORCE : HWMOD_IDLEMODE_SMART;
> > +           /* XXX What about HWMOD_IDLEMODE_SMART_WKUP? */
> 
> What do you mean here?

We're not programming IP block target idle modes to smart idle + wakeup on 
OMAP4.  We're only programming them to smart idle :-(


- Paul