On Mon, 8 Oct 2012, Tony Lindgren wrote: > * Paul Walmsley <p...@pwsan.com> [121007 18:48]: > > > > Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move > > debug_card_init() function") results in the following new sparse[1] > > warning: > > > > arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' > > was not declared. Should it be static? > > > > Normally this could be fixed by including the appropriate header file > > in plat-omap/debug-devices.c, but the header file now exists only in > > mach-omap2/, so this would require a "sideways include" and is thus > > impractical. It turns out that only code in mach-omap2/ currently > > uses the debug-devices.c and debug-leds.c files, so move them there. > > In the long term, these devices should be created by DT, and the code > > should be moved into drivers/ somewhere. > > Hmm are you sure that omap1 is not using debug-leds.c? > At least the initcall seems like it should run on omap1 > if enabled.
Will drop this one for now until we figure out what to do about it. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html