Hi Loic,
On 6 November 2012 06:53, Loic PALLARDY <loic.palla...@st.com> wrote:
>
>
> On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote:
>> Now internal structures can remain hidden to the user and just API
>> related functions and defines are made available.
>>
>> Signed-off-by: Omar Ramirez Luna<omar.l...@linaro.org>
>> ---
>> drivers/mailbox/mailbox.c | 34 ++++++++++++++++++++++++++++++++
>> drivers/mailbox/mailbox.h | 48
>> +--------------------------------------------
>> include/linux/mailbox.h | 22 +++++++++++++++++++
> I agree with the file split but I think mailbox framework API should be
> more generic.
> omap_ prefix should not be used. mailbox_ prefix will be better.
Ok.
> Message type must be more opened like for example:
> struct mailbox_msg {
> int size;
> unsigned char header;
> unsigned char *pdata;
> };
We can analyze the requirement for having such structure, presumably
you expect variable size messages, in OMAP case it is a 4 byte value,
but I'm open to change in order to accommodate other users needs.
Cheers,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
