Re: [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver

[Thierry Reding]

On Wed, Nov 21, 2012 at 06:41:03PM +0530, Philip, Avinash wrote:
[...]
> +static const struct of_device_id ehrpwm_of_match[] = {
> +     {
> +             .compatible     = "ti,am33xx-ehrpwm",
> +     },

Same comment as for patch 4.

> @@ -437,16 +451,41 @@ static int __devinit ehrpwm_pwm_probe(struct 
> platform_device *pdev)
>               dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
>               return ret;
>       }
> -

I think this blank line actually improves readability so it can stay in.

Thierry

pgpgT19DwQRz0.pgp
Description: PGP signature