On 2012-11-28 12:41, Chandrabhanu Mahapatra wrote: > The DISPC specific dss_param_range are moved from struct omap_dss_features to > corresponding DSS version specific dispc_param_range struct, initialized in > dispc_features thereby enabling local access. The mgr_width_max and > mgr_height_max, members of dispc_features, are also moved to > dispc_param_range. > > Signed-off-by: Chandrabhanu Mahapatra <cmahapa...@ti.com> > --- > drivers/video/omap2/dss/dispc.c | 80 > +++++++++++++++++++++++--------- > drivers/video/omap2/dss/dss.h | 4 ++ > drivers/video/omap2/dss/dss_features.c | 16 ------- > drivers/video/omap2/dss/dss_features.h | 3 -- > 4 files changed, 63 insertions(+), 40 deletions(-)
I think the exact same comments, as to the previous patch, apply here. Instead of creating param_range, use the dss_param_range. And see if dispc.feat->params[FEAT_PARAM_PCD].min style lines can be simplified with helper func/pointer. Tomi
signature.asc
Description: OpenPGP digital signature
