On Thursday 10 January 2013 04:18 PM, Santosh Shilimkar wrote:
On Thursday 10 January 2013 03:59 PM, Chen Gang wrote:dma_lch_count is zero before 1st call of omap_system_dma_probe. omap_dma_reserve_channels has value before 1st call of omap_system_dma_probe when 1st call of omap_system_dma_probe we need set dma_lch_count before use it for judging or which will be failed for omap_dma_reserve_channels additional info: this patch is only for fixing bug, not touch the features. so, not use d->lch_count instead of dma_lch_count for the statement: && (omap_dma_reserve_channels <= dma_lch_count))Why not ? Infact thats the right fix as mentioned in the review.at least, now, current fixing is equal to above. in the future maybe omap_dma_reserve_channels can be set by outside (such as from /proc) dma_lch_count is a static global variable which has effect to all devices. maybe the original author do not hope the newer is larger than the older'omap_dma_reserve_channels' when used is suppose to be from command line. Hence the proposed fix in the review is the right one.
Another thing. please fix the subject line. It should be something like below. ARM: OMAP: Fix the use of uninitialized dma_lch_count Regards santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
