On 02/08/2013 11:50 PM, Peter Ujfalusi wrote: > On 02/08/2013 07:56 PM, Jon Hunter wrote: >>> /** >>> * twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0 >>> * @mod_no: module number >>> @@ -322,16 +323,17 @@ int twl_i2c_write(u8 mod_no, u8 *value, u8 reg, >>> unsigned num_bytes) >>> pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no); >>> return -EPERM; >>> } >>> - if (unlikely(!inuse)) { >>> + if (unlikely(!twl_priv->ready)) { >> >> This is causing the kernel to panic on all my omap2 boards when booting >> linux-next >> because twl_priv is not initialised yet. > > Good catch. > I just wonder from where the twl_* call is coming on OMAP2. AFAIK the twl code > is for OMAP3/4, for OMAP2 Menelaus is the one which is used. > I'm currently working on to remove all those twl_* calls from random places in > the kernel so we will only access twl via the MFD stack.
Good point. I just noticed that none of my omap2+ board were booting and on omap3/4 I was the panic in the twl code. I can't say that I checked the panic on omap2, so may be that was another problem? I will update the changelog and re-send the patch. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html