Hi, On Thu, Feb 28, 2013 at 08:09:33PM +0530, Vivek Gautam wrote: > On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi <ba...@ti.com> wrote: > > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi <ba...@ti.com> wrote: > >> > Hi, > >> > > >> > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: > >> >> >> Moreover, SoCs having multiple dwc3 controllers will have multiple > >> >> >> PHYs, which eventually be added using usb_add_phy_dev(), and not > >> >> >> using usb_add_phy(). So each dwc3 controller won't be able to > >> >> >> get PHYs by simply calling devm_usb_get_phy() also. > >> >> > > >> >> > No. We have added usb_get_phy_dev() for that purpose in the case of > >> >> > non-dt. > >> >> > I think, instead you can have a patch to use devm_usb_get_phy_dev() > >> >> > here and > >> >> > in exynos platform specific code use usb_bind_phy() to bind the phy > >> >> > and > >> >> > controller till you change it to dt. > >> >> > > >> >> > >> >> We have dt support for dwc3-exynos, in such case we should go ahead with > >> >> of_platform_populate(), right ? > >> >> But if when i use of_platform_populate() i will not be able to set > >> >> dma_mask to dwc3->dev. :-( > >> > > >> > do you have a special need for dma_mask because OF already sets it. > >> > > >> If i am not wrong of_platform_device_create_pdata() will set > >> "dev->dev.coherent_dma_mask = DMA_BIT_MASK(32)" > >> and not dma_mask. > >> I fact we had some discussion sometime back when we needed the same > >> for dwc3-exynos in the thread: > >> [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree > >> > >> But couldn't get final node on it. > >> So suggestions here please. :-) > > > > hmm.. you're right there. Grant, Rob ? Any hints ? > > > > Any suggestions on this ?
anyone ? -- balbi
signature.asc
Description: Digital signature
