Hi, On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: > + rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); > + abe_dpll = clk_get_sys(NULL, "dpll_abe_ck");
should these two lines be swaped ?
> + if (!rc)
> + rc = clk_set_rate(abe_dpll, OMAP5_DPLL_ABE_DEFFREQ);
> + if (rc)
> + pr_err("%s: failed to configure ABE DPLL!\n", __func__);
> +
> + return 0;
so even if (rc) you still return 0 ? Shouldn't you return rc instead ?
--
balbi
signature.asc
Description: Digital signature
