Re: [PATCH 5/9] pcmcia: add new CIS access helpers

[Komuro]

Hi,

I think "> ETH_ALEN + 3" is not necessary.
The network card with ETH_ALEN + 4 may exist.


        if (tuple->TupleData[0] != CISTPL_FUNCE_LAN_NODE_ID)
                return -EINVAL;
-       if ((tuple->TupleDataLen < ETH_ALEN + 2) || 
-           (tuple->TupleDataLen > ETH_ALEN + 3)) {
+       if (tuple->TupleDataLen < ETH_ALEN + 2) {
                dev_warn(&p_dev->dev, "Invalid CIS tuple length for "
                        "LAN_NODE_ID\n");
                return -EINVAL;
        }


Best Regards
Komuro

_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia