On Saturday 04 of September 2010 12:54:04 Dominik Brodowski wrote:
> Hello Jirka,
>
> On Tue, Aug 31, 2010 at 04:00:05PM +0200, Jirka Klimes wrote:
> > calling pccardctl with an unknown long option causes SIGSEGV;
> > e.g. pccardctl --ver
> >
> > The patch adds missing last zeroed element to options array.
>
> Thanks, nice patch. Could you add a Signed-off-by - line (as per the Linux
> kernel rules, see Documentation/SubmittingPatches for details), please,
> then I'll apply it right away?
>
> Thanks and best wishes,
> Dominik
Calling pccardctl with an unknown long option causes SIGSEGV;
e.g. pccardctl --ver
The patch adds missing last zeroed element to options array.
Signed-off-by: Jirka Klimes <[email protected]>
---
Ok, I include the same patch, now with the sign-off.
Thanks Dominik for pointing me to the rules as I'm not much familiar with
process. I'm going to get to know it closely.
Thanks,
Jirka
diff --git a/src/pccardctl.c b/src/pccardctl.c
index d5cbfef..f945694 100644
--- a/src/pccardctl.c
+++ b/src/pccardctl.c
@@ -394,6 +394,7 @@ static struct option pccardctl_opts[] = {
{ .name="verbose", .has_arg=no_argument, .flag=NULL, .val='v'},
// { .name="socket", .has_arg=required_argument, .flag=NULL, .val='s'},
// { .name="socketdir", .has_arg=required_argument, .flag=NULL, .val='d'},
+ { 0, 0, 0, 0 }
};
static void lspcmcia_socket_available_resources(unsigned long socket_no, char *which) {
_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
