On Tue, Dec 17, 2013 at 07:31:21PM +0100, Robert Jarzmik wrote:
> Thierry Reding <thierry.red...@gmail.com> writes:
>
> > I hadn't anticipated that =(. In fact I had been holding this patch back
> > for a release cycle because I was waiting for a specific regulator patch
> > to land which provides a dummy regulator if one wasn't specified. It
> > seems that that patch only works when booting from DT, though.
> >
> > The correct way to fix this would be to provide a lookup table with the
> > dummy regulator in the board file. I've attached a patch (compile-tested
> > only) that might work.
> >
> > If it does, please let me know and, if nobody else volunteers, I'll see
> > if I can come up with a set of patches to fix this for any other boards
> > that have the same issue.
> Actually, it needs a very small "tweak" to work :
> - REGULATOR_SUPPLY("power", "pwm-backlight.0"),
> + REGULATOR_SUPPLY("power", "pwm-backlight"),
>
> Without it regulator_dev_lookup() won't match the device.
>
> Moreover, it requires a config option, CONFIG_REGULATOR_FIXED_VOLTAGE=y.
> That's
> not a problem for my specific platform,Okay. I'll submit a patch with that tweak of yours rolled in and Haojian can merge that via the PXA tree. > but I haven't seen *any* PXA platform > with it activated, which means all defconfigs have to be patched, which is > unfortunate. Unfortunate indeed! > As for my specific mioa701, your change with the tweak is perfectly fine and > tested. Great, I'll add your Tested-by. Thanks, Thierry
pgpCRzvm5uX1Q.pgp
Description: PGP signature
