Hi,
Vladimir Zapolskiy wrote:
> The changed three user messages on fault are printed under pr_debug(),
> however all of them are unrecoverable and result in failed pwm device
> registration, report this to a user.
>
> Signed-off-by: Vladimir Zapolskiy <[email protected]>
> Cc: Lothar Waßmann <[email protected]>
> Cc: Sascha Hauer <[email protected]>
> Cc: Thierry Reding <[email protected]>
> Cc: Shawn Guo <[email protected]>
> ---
> drivers/pwm/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 681d154..ccf1be7 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -532,19 +532,19 @@ struct pwm_device *of_pwm_get(struct device_node *np,
> const char *con_id)
> err = of_parse_phandle_with_args(np, "pwms", "#pwm-cells", index,
> &args);
> if (err) {
> - pr_debug("%s(): can't parse \"pwms\" property\n", __func__);
> + pr_warn("%s(): can't parse \"pwms\" property\n", __func__);
>
As this is an error that leads to not loading the driver it should be
printed with ERROR level.
> return ERR_PTR(err);
> }
>
> pc = of_node_to_pwmchip(args.np);
> if (IS_ERR(pc)) {
> - pr_debug("%s(): PWM chip not found\n", __func__);
> + pr_warn("%s(): PWM chip not found\n", __func__);
>
dto.
> goto put;
> }
>
> if (args.args_count != pc->of_pwm_n_cells) {
> - pr_debug("%s: wrong #pwm-cells for %s\n", np->full_name,
> + pr_warn("%s: wrong #pwm-cells for %s\n", np->full_name,
>
dto.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | [email protected]
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
