Thierry Thank you very much:)
Best wishes Qipeng -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Thierry Reding Sent: Thursday, March 12, 2015 3:59 PM To: Zha, Qipeng Cc: [email protected]; Westerberg, Mika Subject: Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <[email protected]> > > Add pci device id for Broxton platform. For reference, this should be "PCI" and "ID", but I can fix those up while applying. Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things. You can do so using: $ git format-patch --subject-prefix='PATCH v2' ... The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this: --- Changes in v2: - keep board information table sorted by device ID - reuse Braswell board information Again, no need to resend this time, but something to keep in mind for future patches. > Signed-off-by: qipeng.zha <[email protected]> I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct? Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
