On Thu, Nov 26, 2009 at 11:36 AM, Sasha Khapyorsky <sas...@voltaire.com> wrote: > On 10:35 Mon 16 Nov , Hal Rosenstock wrote: >> > >> > Unlike previous solution where all IPv6 Solicited node multicast (SNM) >> > requests were collapsed into a single multicast group in OpenSM, now >> > each IPv6 SNM group is represented as a separate multicast group and >> > all groups sharing same P_Key and scope values use a same MLID value. >> >> Shouldn't this also ensure groups sharing MLIDs have the same MTU, >> rate, and packet lifetime ? > > For IPv6 SNM it was never implemented, so my rework meets an original > plan.
Yes, it is same as original implementation in that regard but there was little alternative with the approach taken. Now there is but from your comments below it seems you are unclear this is needed. > And in general it is an interesting question. Do we really need to care > about those parameters while doing MGID to MLID compression? SA will > reply properly MGID "based" queries, an "extra" packets will be dropped > anyway, likely sooner is better, no? Not sure what you mean by "extra packets dropped anyway, likely sooner is better". The multicast tree (MLID) has one rate, MTU, etc. so these parameters should be enforced on multicast groups (MGIDs) overlaid on the same MLID. >> > This solution should be fully IBA complaint. >> >> Why the should qualification ? > > Only due to insufficient testing, etc.. > >> Shouldn't the IBA compliant issues fixed be documented here ? > > Yes, but I cannot find where. The only needed change I found is in the > usage message and man page, but there is nothing about IBA compliance. I was saying to add it to the patch description so it would be documented properly. How can it be added now ? -- Hal > Sasha > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
