On 15:10 Wed 13 Jan , Hal Rosenstock wrote: [snip]
> >> @@ -364,6 +375,10 @@ static void clear_port(ib_portid_t * portid, uint16_t > >> cap_mask, > >> performance_reset_via(pc, portid, port, mask, ibd_timeout, > >> IB_GSI_PORT_XMIT_DISCARD_DETAILS, > >> ibmad_port); > >> + mask = 0x3F; > >> + performance_reset_via(pc, portid, port, mask, ibd_timeout, > >> + IB_GSI_PORT_RCV_ERROR_DETAILS, > >> + ibmad_port); > > > > If 'mask' value is used unconditionally whouldn't it be simpler to just > > write: > > > > performance_reset_via(pc, portid, port, 0x3f, ibd_timeout, > > IB_GSI_PORT_RCV_ERROR_DETAILS, > > ibmad_port); > > > > ? > > Yes and that comment also applies to the instance above this for xmit > discard details reset. Ok. Both patches are applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
