On 13:44 Tue 13 Apr , Ira Weiny wrote: > > > This changes the logic. "num_smps_outstanding" is NOT the number on the > > wire, but it appears you have made it so.
Actually yes, it made it so. > > This is the number which will cause process_smp_queue to continue being > > called. > > > > If you are going to do this I think you need to change process_mads as well > > as process_one_recv. We discussed process_one_recv in the error case. process_one_recv() failure breaks the loop anyway. > > What were you trying to fix? > > Ok, I think I see. We should move cl_qmap_insert to after a successful > umad_send and putting total_smps here is ok. But num_smps_outstanding should > be put back I think. But then it blocks process_mads() to loop forever after single send_smp() failure (with all empty queues and umad_recv() running without timeout). Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
