pci_enable_pcie_error_reporting() is optional. ________________________________________ From: linux-rdma-ow...@vger.kernel.org [linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe [jguntho...@obsidianresearch.com] Sent: Friday, October 22, 2010 2:36 PM To: Ralph Campbell Cc: RDMA list Subject: Re: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable
On Fri, Oct 22, 2010 at 02:28:54PM -0700, Ralph Campbell wrote: > I'm not sure this is the right change. I agree there are a lot of > clean up on error bugs. pci_set_consistent_dma_mask() isn't optional > because the chip doesn't support 32-bit PCIe addressing. Do you think pci_enable_pcie_error_reporting is optional? My test machine doesn't have a chipset with AER so that will always fail (or something), the driver hasn't exploded yet ... :) > I'll look it over and try to come up with something better. > > I'll submit a patch for the CONFIG_PCI_MSI not set case. The resource leaks suck too, since you have to reboot to try again. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
