On Fri, Oct 22, 2010 at 02:25:11PM -0700, Roland Dreier wrote:
>  > @@ -1801,6 +1831,11 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct 
> ib_send_wr *wr,
>  >            ctrl->owner_opcode = mlx4_ib_opcode[wr->opcode] |
>  >                    (ind & qp->sq.wqe_cnt ? cpu_to_be32(1 << 31) : 0) | blh;
>  >  
>  > +          if (vlan < 0x1000) {
>  > +                  ctrl->ins_vlan = 1 << 6;
>  > +                  ctrl->vlan_tag = vlan;
>  > +          }
> 
> Looks like a bug here -- vlan is __be16 and holds the vlan tag in
> network order.  So this should be a test of be16_to_cpu(vlan) < 0x1000, right?
> 

Sure, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to