On 7/8/2011 5:50 PM, Jason Gunthorpe wrote: > On Fri, Jul 08, 2011 at 05:42:38PM -0400, Hal Rosenstock wrote: > >> Should the request just be a GET rather than GET_TABLE and avoid this >> check ? I don't think multiple nodes can register with same Node GUID, >> can they ? Also, I think it makes eliminates this check and the missing >> 0 check. > > Multiport HCAs should (and do..) show up with multiple node > records. There is one node record per end port, not per node. This is > why using node GUID as an end port identifier is a bad choice.
Before this patch, it did used to use the port GUID for this. > However, you could use GET and look at the return code to disambiguate > no records/one record/many records. Yes, that was getting at (and that there was no check for no records returned with the get table code). -- Hal > Jason > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
