The feature is critical to our performance and unfortunately differs by CPU.

I'm open to pushing code into arch/lib/x86...

Mike

> -----Original Message-----
> From: Hefty, Sean [mailto:[email protected]]
> Sent: Wednesday, November 09, 2011 11:49 AM
> To: Mike Marciniszyn; [email protected]
> Cc: [email protected]
> Subject: RE: [PATCH V2 6/7] IB/qib: memcpy optimizations
>
> > This fix adds an x86_64 specific routine that 1) probes for
> > X86_FEATURE_REP_GOOD
> > and 2) uses an inline asm routine builton rep movsq that testing has
> shown is
> > better than the builtin memcpy for all cases up to 4K.  The probing
> routine is
> > now called when the qib module is loaded to enable the optimization.
> When
> > X86_FEATURE_REP_GOOD is not set, the routine uses the kernel's
> unrolled
> > __memcpy
> > when the length is more than 64 and the builtin memcpy otherwise.
>
> Having every driver implement their own version of memcpy is a bad
> idea.


This message and any attached documents contain information from QLogic 
Corporation or its wholly-owned subsidiaries that may be confidential. If you 
are not the intended recipient, you may not read, copy, distribute, or use this 
information. If you have received this transmission in error, please notify the 
sender immediately by reply e-mail and then delete this message.
N�����r��y����b�X��ǧv�^�)޺{.n�+����{��ٚ�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i

Reply via email to