On Mon, Dec 19, 2011 at 12:07 AM, David Dillow <[email protected]> wrote: > On Thu, 2011-12-01 at 20:08 +0100, Bart Van Assche wrote: >> Eliminate the private_rport_attrs[] array and the SETUP_*() macros >> used to set up that array since the information in that array >> duplicates the information in the static device attributes. Also, >> trigger a kernel warning if SRP_RPORT_ATTRS is not large enough >> since it is easy to forget to update that macro when adding new >> attributes. > > Not sure I care one way or the other, but it looks to have been written > the way it was to share a common code structure with the FC, SAS, and > other SCSI transport code.
My opinion about the SETUP_*() macros is that - at least in the SRP transport code - they make the code harder to read without having any real value and hence should be removed. > They use a BUG_ON instead of WARN_ON, which > seems more appropriate, since we just overran a buffer... Sorry, but I disagree. The guideline for Linux kernel code is to use BUG_ON() only if a crash can't be avoided. With SLUB red zoning enabled it is still possible to unload kernel modules after a (mild) buffer overrun. And if you have a look at mm/slub.c, you will see that slab_err() is invoked in case padding has been overwritten. That last function does something similar to WARN_ON(). Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
