On 2/2/2012 4:38 PM, Eric Dumazet wrote:
Maybe we can keep a fastpath for ethernet case... (the "if (hlen == ETH_HLEN)
being always predicted) Maybe need to introduce gro_hard_header_len as well)
today, IPoIB advertizes hard_header_len which is bigger than the IPoIB
header len, this is done such that skbs sent by the network stack have
enough headroom for a "pseudoheader" which for few flows (e.g unicast
arp replies and multicast) is placed there by the ipoib hard_header
function and later used by the xmit function.
So we can either try and change that, such that hard_header_len will be equal
to the ipoib header len or add gro_hard_header_len as you suggested, any
preferences?
I guess changing hard_header_len might be difficult (for you).
Adding gro_mac_header_len sounds the easy way. [ You'll need to set it in your
device setup() ]
Eric, yep, I'm okay with adding gro_mac_header_len, such that if the
device setup function doesn't touch it, the core sets it to
hard_header_len and later the gro code uses that len in the comparison
you have placed in your patch. The ipoib setup code will set that field
to the IPoIB header size. If you enhance a bit your patch to include
that I could do the testing or you prefer me to do that? do you think we
need two or one patch here?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
