On Wed, Mar 21, 2012 at 10:42 AM, frank zago
<fz...@systemfabricworks.com> wrote:
> On 03/20/2012 05:39 PM, parav.pan...@emulex.com wrote:
>> +struct ib_mr *ocrdma_get_dma_mr(struct ib_pd *ibpd, int acc)
>> +{
>> + struct ocrdma_mr *mr;
>> +
>> + mr = ocrdma_alloc_lkey(ibpd, acc, 0, OCRDMA_ADDR_CHECK_DISABLE);
>> + if (!mr)
>> + return ERR_PTR(-ENOMEM);
>
> ocrdma_alloc_lkey does not return NULL on error.
Good catch! Even more to the point, ocrdma_alloc_lkey() doesn't return a
struct ocrdma_mr* on success. So this function is totally broken.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
