On 03/20/2012 05:39 PM, parav.pan...@emulex.com wrote: > From: Parav Pandit <parav.pan...@emulex.com>
> + > +int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey) > +{ > + int status = -ENOMEM; > + struct ocrdma_dealloc_lkey *cmd; > + > + cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_DEALLOC_LKEY, sizeof(*cmd)); > + if (!cmd) > + return -ENOMEM; > + cmd->lkey = lkey; > + cmd->rsvd_frmr = fr_mr ? 1 : 0; > + status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > + if (status) > + goto mbx_err; > +mbx_err: Missing return before the tag ? Or unnecessary goto. > + kfree(cmd); > + return status; > +} -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html