On Wed, Sep 5, 2012 at 4:25 PM, Max Matveev <m...@gmx.co.uk> wrote: > On Tue, 4 Sep 2012 11:02:32 -0700, Roland Dreier wrote: > > roland> On Tue, Sep 4, 2012 at 1:12 AM, Max Matveev <m...@gmx.co.uk> wrote: > >> What about races between radix_tree_extend and radix_tree_lookup? > >> > >> As far as I can see (even on newer kernels with rcu support) there is > >> nothing which protects changes to node->height and it is used to > >> decide how deep lookup must go to find the actual data. > > roland> I assume things are ordered so that lookups that follow the > roland> old data can still find old entries, and that updates become > roland> visible in a consistent order. > > I honestly do see how - the height of the root node is updated > indepedently of the slots, so if someone managed to get the updated > height there is nothing from stoping radix_tree_lookup from going too > deep into the chain of slots. > > Also most other places which call radix_tree_lookup do use some kind > of lock around it.
same here putting your response on linux-rdma@vger.kernel.org as it was wrongly sent to linux-rdma-ow...@vger.kernel.org ... Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
