> > +static inline uint32_t ibv_get_srq_num(struct ibv_srq *srq)
> > +{
> > + struct verbs_context *vctx = verbs_get_ctx_op(srq->context,
> > get_srq_num);
> > + if (!vctx) {
> > + errno = ENOSYS;
> > + return 0;
> > + }
> > + return vctx->get_srq_num(srq);
> > +}
>
> Do you think the function pointer indirection for ibv_get_srq_num is
> needed? I had thought something like:
Needed? No - but I was trying to keep the verbs definitions in driver.h away
from the user.
> Where has_comp_mask is a bitmask from the provider with each bit
> indicating if a provider allocated structure is extended with
> comp_mask. The driver is required to allocate all structures of that
> type with a comp_mask if the bit is set.
I like the concept of has_comp_mask. I'll add that.
- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
