On Tue, Jun 04, 2013 at 09:49:00PM +0000, Hefty, Sean wrote:
> > > +uint32_t          qp_num;     /* QP number */
> > > +void             *qp_context; /* Associated context of the QP */
> > 
> > Would be nice to clarify what this value is too. I took a quick peak
> > and it wasn't clear to me. The XRC example does not use it.
> > 
> > Is it a user defined cookie? If so can we call it a cookie instead?
> 
> This is similar to qp_context in ibv_qp_init_attr and ibv_qp, which
> is also consistent with cq_context and srq_context.  It is a user
> defined context.

Hum, I honestly had no idea about qp_context in struct ibv_qp, it
really is not documented well..

Keep the name, but please clarify what it is:

 'User defined opaque value'

Ideally in the other places too..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to