On Fri, 2013-06-28 at 14:48 +0200, Bart Van Assche wrote: > Avoid that srp_claim_command() can claim a command while
I think you meant srp_claim_req() ? > srp_queuecommand() is still busy queueing the same command. > Found this via source reading. The main issue seems to be a broken, possibly malicious, target? I'm not sure I see another path to get into this race, as the scsi layer should protect us from queue submission and error handling at the same time, correct? I'm not keen on giving up the command submission concurrency we worked so hard to get -- you completely serialize command submission again. If we really need to protect against this race -- and we probably should, to guard against broken targets -- I think we can achieve the concurrency and safety by improving the receive and error handling sides -- especially if we can push it into error handling, as that's already a slow path. Let's push this patch to the back of the pile for any respin; I don't think the others rely on it (haven't gotten there yet) and would rather not hold them up for this. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
