On Wed, Jul 3, 2013 at 10:26 PM, Roland Dreier <rol...@kernel.org> wrote: > On Wed, Jul 3, 2013 at 9:41 AM, Or Gerlitz <ogerl...@mellanox.com> wrote: > > Jack looked on this comment/code and he says that the active flag is used > > to prevent re-scheduling the timer from inside the timer handling routine. > > > > In the kernel, the comment header in the source file for del_timer_sync > > explicitly states that re-scheduling the timer must be prevented, > > or the sync is useless:Callers must prevent restarting of the timer, > > otherwise > > this function is meaningless > > > > So we believe that code should remain. > > Look at the actual timer code. del_timer_sync() won't work if > something unrelated re-adds the timer, but it will work if the timer > itself is what re-adds itself.
[...] OK, we will re-look into that tomorrow. So how V2 looks? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
