On 26/8/2013 10:07 PM, Roland Dreier wrote:
On Wed, Aug 14, 2013 at 3:58 AM, Or Gerlitz <ogerl...@mellanox.com> wrote:
+struct _ib_flow_spec {
Just out of curiousity, why does this structure name start with "_"?
In fact why have the struct at all, since all it's doing is wrapping
an anonymous union? Does the following work:
+union ib_flow_spec {
+ struct {
+ enum ib_flow_spec_type type;
+ u16 size;
+ };
+ struct ib_flow_spec_eth eth;
+ struct ib_flow_spec_ipv4 ipv4;
+ struct ib_flow_spec_tcp_udp tcp_udp;
+ };
+};
If that works, then that seems a lot nicer to me...
- R.
There's no real good reason for that. The struct isn't needed and we'll
definitely change that for V6.
- Matan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
