> -----Original Message----- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Monday, September 16, 2013 7:20 AM > Subject: [PATCH infiniband-diags] ibdiag_sa.c: Output attribute ID in hex > rather than decimal > > > so that it's easier to correlate to IBA spec > > For example: > saquery PKTR 20/1/0 --smkey 1 > ibwarn: sa_query: umad_send failed: attr 51: Bad file description > > 0x33 would be easier than 51 as no conversion is required to look it up in IBA > spec. > > Signed-off-by: Hal Rosenstock <h...@mellanox.com>
Thanks, applied, Ira > --- > diff --git a/src/ibdiag_sa.c b/src/ibdiag_sa.c index 7a5014c..018a428 100644 > --- a/src/ibdiag_sa.c > +++ b/src/ibdiag_sa.c > @@ -112,7 +112,7 @@ int sa_query(struct sa_handle * h, uint8_t method, > > ret = umad_send(h->fd, h->agent, umad, len, ibd_timeout, 0); > if (ret < 0) { > - IBWARN("umad_send failed: attr %u: %s\n", > + IBWARN("umad_send failed: attr 0x%x: %s\n", > attr, strerror(errno)); > free(umad); > return (-ret); -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html