Hello Naresh Gottumukkala,

The patch 7c33880c3cb2: "RDMA/ocrdma: Add support for fast register 
work requests (FRWR)" from Aug 26, 2013, leads to the following 
warning:
"drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1986 ocrdma_build_fr()
         warn: impossible condition '(wr->wr.fast_reg.length > 4294967295) => 
(0-u32max > u32max)'"

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
  1974  static int ocrdma_build_fr(struct ocrdma_qp *qp, struct ocrdma_hdr_wqe 
*hdr,
  1975                             struct ib_send_wr *wr)
  1976  {
  1977          u64 fbo;
  1978          struct ocrdma_ewqe_fr *fast_reg = (struct ocrdma_ewqe_fr *)(hdr 
+ 1);
  1979          struct ocrdma_mr *mr;
  1980          u32 wqe_size = sizeof(*fast_reg) + sizeof(*hdr);
  1981  
  1982          wqe_size = roundup(wqe_size, OCRDMA_WQE_ALIGN_BYTES);
  1983  
  1984          if ((wr->wr.fast_reg.page_list_len >
  1985                  qp->dev->attr.max_pages_per_frmr) ||
  1986                  (wr->wr.fast_reg.length > 0xffffffffULL))
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This condition can never be true.

  1987                  return -EINVAL;
  1988  
  1989          hdr->cw |= (OCRDMA_FR_MR << OCRDMA_WQE_OPCODE_SHIFT);
  1990          hdr->cw |= ((wqe_size / OCRDMA_WQE_STRIDE) << 
OCRDMA_WQE_SIZE_SHIFT);
  1991  

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to