From: Vu Pham <vuhu...@mellanox.com> srp_reconnect_rport() serializes calls of srp_rport_reconnect() with srp_queuecommand(), srp_abort(), srp_reset_device(), srp_reset_host() via rport->mutex and also blocks srp_queuecommand(); however, it cannot block scsi error handler commands (stu, tur). This may introduces corruption in free_tx IUs list and IU itself
Signed-off-by: Vu Pham <vuhu...@mellanox.com> Signed-off-by: Sagi Grimberg <sa...@mellanox.com> --- drivers/infiniband/ulp/srp/ib_srp.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index b615135..656602b 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -859,6 +859,7 @@ static int srp_rport_reconnect(struct srp_rport *rport) { struct srp_target_port *target = rport->lld_data; int i, ret; + unsigned long flags; srp_disconnect_target(target); /* @@ -882,9 +883,11 @@ static int srp_rport_reconnect(struct srp_rport *rport) srp_finish_req(target, req, DID_RESET << 16); } + spin_lock_irqsave(&target->lock, flags); INIT_LIST_HEAD(&target->free_tx); for (i = 0; i < target->queue_size; ++i) list_add(&target->tx_ring[i]->list, &target->free_tx); + spin_unlock_irqrestore(&target->lock, flags); if (ret == 0) ret = srp_connect_target(target); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html