On 6/16/2014 10:45 AM, Levente Kurusa wrote:
On 06/16/2014 05:37 PM, Nick Krause wrote:
Signed-off-by: Nicholas Krause <xerofo...@gmail.com>
---
drivers/infiniband/hw/cxgb4/
cm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c
b/drivers/infiniband/hw/cxgb4/cm.c
index f9477e2..2d56983 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -340,15 +340,13 @@ static int status2errno(int status)
*/
static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t
gfp)
{
if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) {
skb_trim(skb, 0);
skb_get(skb);
skb_reset_transport_header(skb);
} else {
+ if (skb)
/* NULL is ignored */.
+ kfree_skb (skb);
skb = alloc_skb(len, gfp);
}
t4_set_arp_err_handler(skb, NULL, NULL);
This patch is severely whitespace damaged. Can you fix your MUA
or try to use git-send-email?
The changelog as well is of low quality. Maybe something like this:
infiniband: cxgb4: fix memory skb memory leak
... would be better.
Also, this fails the build, due to the extra dot character after
the comment. :-(
Agreed. Start over with this patch, do what we asked, and make sure it
passes checkpatch...
Thanks,
Levente Kurusa.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
