Hello Steve, >>Doesn't this feature require provider support? It seems like this patch >>really doesn't do anything yet. It is a fix for the client registration logic. When the user space port mapper is restarted, the IWPM_PREV_REG_CLIENTs send their mapping information to the port mapper, afterwards they are allowed to send remove mapping requests and they should be.
If you look at the remove mapping request logic, you see that only registered clients are allowed to make a remove mapping request. In other words, without this fix there are just registered and non-registered clients. IWPM_PREV_REG_CLIENTs are handled like non-registered clients, so their remove mapping requests aren't allowed to go the port mapper, when the rdma application closes the connections in use. No provider support is necessary. Thanks, Tatyana -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Steve Wise Sent: Thursday, October 16, 2014 2:47 PM To: Nikolova, Tatyana E; 'Roland Dreier' Cc: Lacombe, John S; [email protected] Subject: RE: [PATCH 1/1] RDMA/core: Fixes for port mapper client registration > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Tatyana > Nikolova > Sent: Thursday, October 16, 2014 11:20 AM > To: Roland Dreier > Cc: [email protected]; [email protected]; > [email protected] > Subject: [PATCH 1/1] RDMA/core: Fixes for port mapper client > registration > > IWPM_REG_CLIENT and IWPM_PREV_REG_CLIENT are added: > > IWPM_REG_CLIENT is a client, registered with the user space port > mapper daemon, available at the time of the client register pid > request. > IWPM_PREV_REG_CLIENT is a client, which has been IWPM_REG_CLIENT > before the user space port mapper daemon is stopped. > After restarting the port mapper, IWPM_PREV_REG_CLIENTs provide their > mapping info to the port mapper daemon and they are allowed to send > remove mapping requests aftewards. > Hey Tatyana, Nit: "aftewards" is misspelled. Doesn't this feature require provider support? It seems like this patch really doesn't do anything yet. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
