On Mon, Apr 13, 2015 at 02:36:45PM +0200, Michael Wang wrote:
> We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe()
> is no longer necessary, thus clean it up.
So, the net result is not looking too bad, but I'm confused about the
structure of this series.
Why introduce query_transport early on?
Why is the patch series going through this progression most lines?
- if (rdma_port_get_link_layer(device, port_num) ==
IB_LINK_LAYER_INFINIBAND) {
+ if (rdma_tech_ib(device, port_num)) {
+ if (cap_ib_smi(device, port_num)) {
This would be a lot shorter and simpler to look at if the cap's were
introduced first, then their implementation finalized.
I thought we agreed Doug's bitmask plan should be the final
destination for this series, so this progress seems even stranger?
I would be very happy to see a patch that adds cap_ib_smi to the
current tree and states 'This patch is tested to have no change on the
binary compilation results'
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
