Hi, Moni On 06/10/2015 11:13 AM, Moni Shoua wrote: > Registering an event handler is done for a device. This device may have > one RoCE port (no SA cap) and one InfiniBand port (has SA cap). > Therefore, warning from the event handler about a specific port that > doesn't have SA cap is correct but pollutes the kernel log without a > need.
Maybe we should think about register event handler per port :-P Regards, Michael Wang > > Signed-off-by: Moni Shoua <mo...@mellanox.com> > --- > drivers/infiniband/core/multicast.c | 2 +- > drivers/infiniband/core/sa_query.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/core/multicast.c > b/drivers/infiniband/core/multicast.c > index 605f20a..1244f02 100644 > --- a/drivers/infiniband/core/multicast.c > +++ b/drivers/infiniband/core/multicast.c > @@ -780,7 +780,7 @@ static void mcast_event_handler(struct ib_event_handler > *handler, > int index; > > dev = container_of(handler, struct mcast_device, event_handler); > - if (WARN_ON(!rdma_cap_ib_mcast(dev->device, event->element.port_num))) > + if (!rdma_cap_ib_mcast(dev->device, event->element.port_num)) > return; > > index = event->element.port_num - dev->start_port; > diff --git a/drivers/infiniband/core/sa_query.c > b/drivers/infiniband/core/sa_query.c > index 7f7c8c9..3d0b7b2 100644 > --- a/drivers/infiniband/core/sa_query.c > +++ b/drivers/infiniband/core/sa_query.c > @@ -450,7 +450,7 @@ static void ib_sa_event(struct ib_event_handler *handler, > struct ib_event *event > struct ib_sa_port *port = > &sa_dev->port[event->element.port_num - > sa_dev->start_port]; > > - if (WARN_ON(!rdma_cap_ib_sa(handler->device, port->port_num))) > + if (!rdma_cap_ib_sa(handler->device, port->port_num)) > return; > > spin_lock_irqsave(&port->ah_lock, flags); > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html