On Tue, Jun 30, 2015 at 09:45:55AM -0400, [email protected] wrote: > +static inline int ib_nl_is_good_resolve_resp(const struct nlmsghdr *nlh) > +{ > + const struct nlattr *head, *curr; > + int len, rem; > + > + if (nlh->nlmsg_flags & RDMA_NL_LS_F_ERR) > + return 0; > + > + if (!(nlh->nlmsg_flags & RDMA_NL_LS_F_OK)) > + return 0; > + > + if (nlmsg_len(nlh) < nla_attr_size(sizeof(*rec))) > + return 0;
Um, why are you sending patches that are not even compile tested? drivers/infiniband/core/sa_query.c: In function 'ib_nl_is_good_resolve_resp': drivers/infiniband/core/sa_query.c:732:45: error: 'rec' undeclared (first use in this function) if (nlmsg_len(nlh) < nla_attr_size(sizeof(*rec))) This routine should also be using nla_parse and friends, not a roll your own. And you didn't address all the comments either.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
