On Wed, Jul 22, 2015 at 10:34:05AM -0600, Jason Gunthorpe wrote:
> > +/**
> > + * ib_alloc_mr() - Allocates a memory region
> > + * @pd: protection domain associated with the region
> > + * @mr_type: memory region type
> > + * @max_entries: maximum registration entries available
> > + * @flags: create flags
> > + */
>
> Can you update this comment to elaborate some more on what the
> parameters are? 'max_entries' is the number of s/g elements or
> something?
>
> > +enum ib_mr_type {
> > + IB_MR_TYPE_FAST_REG,
> > + IB_MR_TYPE_SIGNATURE,
> > };
>
> Sure would be nice to have some documentation for what these things
> do..
Agreed on both counts. Otherwise this looks pretty good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
