On 07/23/2015 05:48 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2015 at 05:41:38PM -0400, Doug Ledford wrote:
> 
>> I assume this prevents the driver from working at all on certain arches
>> (like ppc with 64k page size)?
> 
> Nothing uses page_size_cap correctly, so it has no impact.

OK, then I'm going to skip this for 4.2-rc and bump it on out to 4.3.

> Sagi, that is a good point, your generic code for the cleanup series
> really should check that PAGE_SIZE is in page_size_cap and at least
> fail the mr allocation if it isn't...
> 
> Maybe that would be enough to drop SRP's bogus usage of it...
> 
> Jason
> 


-- 
Doug Ledford <dledf...@redhat.com>
              GPG KeyID: 0E572FDD


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to