> @@ -1040,6 +1040,181 @@ static int cma_save_net_info(struct sockaddr
> *src_addr,
>       return cma_save_ip_info(src_addr, dst_addr, ib_event, service_id);
>  }
> 
> +struct cma_req_info {
> +     struct ib_device *device;
> +     int port;
> +     const union ib_gid *local_gid;

The use of a pointer to some gid inside some other structure looks 
questionable.  There's no reference count held on another structure.  We would 
be better off copying the GID or setting an index into the device GID table.

> +     __be64 service_id;
> +     u16 pkey;
> +};

Please relocate to the top of the source file to group it with other structure 
definitions.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to