On Tue, Aug 04, 2015 at 05:03:24PM +0300, Yishai Hadas wrote: > Signed-off-by: Yishai Hadas <yish...@mellanox.com> > Signed-off-by: Shachar Raindel <rain...@mellanox.com> > drivers/infiniband/core/uverbs.h | 3 +- > drivers/infiniband/core/uverbs_main.c | 43 > +++++++++++++++++++++++---------- > 2 files changed, 32 insertions(+), 14 deletions(-)
This looks OK Reviewed-by: Jason Gunthorpe <jguntho...@obsidianresearch.com> > @@ -798,6 +806,7 @@ static int ib_uverbs_open(struct inode *inode, struct > file *filp) > mutex_init(&file->mutex); > > filp->private_data = file; > + kobject_get(&dev->kobj); Minor quibble, this and the matching put can be dropped. Seeing container_of followed by a get with out a copy is a red flag to anyone reading this code. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
