> > > +enum ib_csum_cap_flags {
> > > + IB_CSUM_RX_TCP_UDP = 1 << 0,
> > > + IB_CSUM_RX_IP_HDR = 1 << 1,
> > > + IB_CSUM_TX_TCP_UDP = 1 << 2,
> > > + IB_CSUM_TX_IP_HDR = 1 << 3
> > > +};
> >
> > TPC and UDP should be separate flags.
>
> Can you explain why?
For the same reason that you didn't include *all* L4 headers.
> What we are advertising here is offloads for L3 and L4 checksums, why
> should it be per protocol?
Because UDP and TCP have different headers, and it's entirely possible for a
NIC (e.g. usnic) to support offloading one but not the other.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
