On Mon, Aug 24, 2015 at 09:52:14AM +0300, Haggai Eran wrote: > Okay. Maybe you can just add a case for IB_WR_SEND in this patch to > avoid hurting bisectability.
I've done this already, just waiting for more feedback before resending: http://git.infradead.org/users/hch/rdma.git/commitdiff/20f34ca8ecac302984f3a92b9ad29f5f4b41780d > Looking at the uverbs part in patch 2, I think the changes are okay. I > noticed there's a (__be32 __force) cast of the immediate data from > userspace (it was already in the existing code). I wonder, why not > define the field in the uapi struct as __be32 in the first place? It looks odd to me as well, but it's not really something I want to change in this series. Note that sparse annoted types like __be32 aren't really common in userspace, but with a bit of effort they can be supported. We have them and regularly run sparse for xfsprogs for example. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
